Hi @dims. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

/ok-to-test

thanks @ivanvc

Codecov Report

Attention: Patch coverage is 13.95349% with 37 lines in your changes missing coverage. Please review.

Project coverage is 68.74%. Comparing base (5d47d7f) to head (da7dd38).
Report is 31 commits behind head on main.

@@            Coverage Diff             @@
##             main   #19195      +/-   ##
==========================================
- Coverage   68.76%   68.74%   -0.02%     
==========================================
  Files         420      420              
  Lines       35650    35685      +35     
==========================================
+ Hits        24514    24532      +18     
- Misses       9714     9727      +13     
- Partials     1422     1426       +4     

/test pull-etcd-integration-2-cpu-amd64

/assign @ahrtr @serathius

Thanks @dims for the PR.

I did some sanity test on this PR, and compared it with the existing main branch.

• Confirmed that this PR can generate the same gRPC counter metrics as the existing main branch, including
  • grpc_server_handled_total
  • grpc_server_msg_received_total
  • grpc_server_msg_sent_total
  • grpc_server_started_total
• It couldn't generate the histograms metrics, but the existing main branch can.
  • grpc_server_handling_seconds_bucket
  • grpc_server_handling_seconds_count
  • grpc_server_handling_seconds_sum

Also references:

• https://github.com/grpc-ecosystem/go-grpc-prometheus
• https://github.com/grpc-ecosystem/go-grpc-middleware/blob/main/examples/server/main.go

Do we need a test to confirm that no metric was removed?

It couldn't generate the histograms metrics, but the existing main branch can.
grpc_server_handling_seconds_bucket
grpc_server_handling_seconds_count
grpc_server_handling_seconds_sum

@ahrtr did you run with --metrics 'extensive' option? or let it default to 'basic'?

Do we need a test to confirm that no metric was removed?

i think so for future-proofing!

@ahrtr did you run with --metrics 'extensive' option?

YES, I executed the same command on this PR and the main branch. The main branch was working as expected, but this PR did not generate the histograms metrics.

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dims
Once this PR has been reviewed and has the lgtm label, please ask for approval from ahrtr. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

@ahrtr found the issue and hopefully fixed it. Added a test as well. However, please check if i broke anything in the process of threading the option through to both the test suite and the main binary.

/test pull-etcd-integration-2-cpu-amd64

/test pull-etcd-robustness-arm64

Do we need a test to confirm that no metric was removed?

@serathius Done! see new test case. If there are other metrics we can trigger them and then add to the list.

@serathius @ahrtr the follow up PR once this merges will be https://github.com/etcd-io/etcd/pull/19242/files

/test pull-etcd-unit-test-386